remoteSearch: Fetch enabled/disabled list once

GLib should be caching the values but it seems unnecessary to fetch
and marshal what should be the same lists N times instead of just once

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1791>

diff --git a/js/ui/remoteSearch.js b/js/ui/remoteSearch.js
index 77ad317e1ef6f4a028b4a8fa7e7391e50df6f519..137516bdcb03106ae7edcd71e23361f3e9e2b4f0 100644 (file)
--- a/js/ui/remoteSearch.js
+++ b/js/ui/remoteSearch.js
@@ -142,16 +142,16 @@ function loadRemoteSearchProviders(searchSettings, callback) {
     // Special case gnome-control-center to be always active and always first
     sortOrder.unshift('gnome-control-center.desktop');
 
+    const disabled = searchSettings.get_strv('disabled');
+    const enabled = searchSettings.get_strv('enabled');
+
     loadedProviders = loadedProviders.filter(provider => {
         let appId = provider.appInfo.get_id();
 
-        if (provider.defaultEnabled) {
-            let disabled = searchSettings.get_strv('disabled');
+        if (provider.defaultEnabled)
             return !disabled.includes(appId);
-        } else {
-            let enabled = searchSettings.get_strv('enabled');
+        else
             return enabled.includes(appId);
-        }
     });
 
     loadedProviders.sort((providerA, providerB) => {